Fix cursor positioning when Console.BufferWidth exceeds Console.WindowWidth#7305
Open
Fix cursor positioning when Console.BufferWidth exceeds Console.WindowWidth#7305
Conversation
…l positioning Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix console output for large BufferWidth values
Fix cursor positioning when Console.BufferWidth exceeds Console.WindowWidth
Jan 28, 2026
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
nohwnd
reviewed
Jan 29, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where test progress timings were displayed incorrectly or not at all when Console.BufferWidth exceeds Console.WindowWidth. The fix ensures ANSI cursor positioning uses the visible window dimensions rather than the larger buffer dimensions.
Changes:
- Added
WindowWidthandWindowHeightproperties to theIConsoleinterface to distinguish between buffer and visible window dimensions - Updated terminal implementations (
SimpleTerminalandAnsiTerminal) to use window dimensions for their Width/Height properties instead of buffer dimensions - Added comprehensive tests to verify the fix and prevent regression
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Platform/Microsoft.Testing.Platform/Helpers/System/IConsole.cs |
Added WindowWidth and WindowHeight properties to the IConsole interface |
src/Platform/Microsoft.Testing.Platform/Helpers/System/SystemConsole.cs |
Implemented WindowWidth and WindowHeight properties by delegating to Console.WindowWidth/WindowHeight |
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/SimpleTerminalBase.cs |
Changed Width and Height properties to use Console.WindowWidth/WindowHeight instead of BufferWidth/BufferHeight |
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.cs |
Changed Width and Height properties to use Console.WindowWidth/WindowHeight instead of BufferWidth/BufferHeight |
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs |
Added tests for SimpleTerminal and AnsiTerminal using WindowWidth, added comprehensive regression test, updated StringBuilderConsole mock, and updated expected ANSI cursor positions from 242 to match new WindowWidth-based calculations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Console.BufferWidthis set larger thanConsole.WindowWidth, test progress timings display incorrectly or not at all. MTP uses ANSI cursor positioning to place timings on the right edge, but was calculating positions usingBufferWidthinstead ofWindowWidth.Changes
IConsole interface
WindowWidthandWindowHeightpropertiesTerminal implementations
SimpleTerminalandAnsiTerminalnow useWindowWidth/WindowHeightinstead ofBufferWidth/BufferHeightfor theirWidth/HeightpropertiesTests
SimpleTerminal_UsesWindowWidthNotBufferWidthandAnsiTerminal_UsesWindowWidthNotBufferWidthto verify behavior when buffer ≠ window dimensionsExample scenario
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
5rqvsblobprodcus385.vsblob.vsassets.io/home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.26077.1.txt(dns block)/usr/bin/dotnet dotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj -c Release kload.emscripten.net9(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.